Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add GitHub Workflow #132

Merged
merged 6 commits into from
Mar 6, 2024
Merged

ci: Add GitHub Workflow #132

merged 6 commits into from
Mar 6, 2024

Conversation

seanpoulter
Copy link
Contributor

@seanpoulter seanpoulter commented Mar 5, 2024 •
edited
Loading

Description

Add a GitHub Workflow

  • Add .nvmrc
  • Extract the "lint" npm script
  • Replace .codeclimate.yml and .travis.yml with .github/workflows/ci.yml

Checklist

  • Unit/Integration test added (if applicable)
  • Documentation added/updated (wiki or md)
  • Code style is consistent with the rest of the project

Background

  • I expect this to help keep the updates in Update service to ESM and WDIO v8 #126 smaller. The tests will fail until we fix the problems with ChromeDriver.
  • I expect that we are not using Travis CI or Code Climate anymore

christian-bromann
christian-bromann approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@seanpoulter
Copy link
Contributor Author

The Workflow fails in test:app. It downloads Chromedriver 112 which we do not expect to work with Chrome 122. That should be fixed in #126 as we upgrade from v7 to v8.

@seanpoulter seanpoulter merged commit 6a6a218 into webdriverio-community:master Mar 6, 2024
1 check failed
@seanpoulter seanpoulter mentioned this pull request Mar 6, 2024
Draft
3 tasks
@seanpoulter seanpoulter deleted the github-workflow branch March 22, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanpoulter @christian-bromann